forked from NVIDIA/spark-rapids
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shuffle gpu serde #28
Open
wjxiz1992
wants to merge
25
commits into
nvliyuan:0625
Choose a base branch
from
firestarman:shuffle-gpu-serde
base: 0625
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Signed-off-by: Firestarman <[email protected]>
Signed-off-by: Firestarman <[email protected]>
Signed-off-by: Firestarman <[email protected]>
Signed-off-by: Firestarman <[email protected]>
Signed-off-by: Firestarman <[email protected]>
…uffle-gpu-serde Signed-off-by: Firestarman <[email protected]>
Signed-off-by: Firestarman <[email protected]>
Signed-off-by: Firestarman <[email protected]>
* Add GpuBucketingUtils shim to Spark 4.0.0 * Signing off Signed-off-by: Raza Jafri <[email protected]> --------- Signed-off-by: Raza Jafri <[email protected]>
* Improve the diagnostics for 'conv' fallback explain Signed-off-by: Jihoon Son <[email protected]> * don't use nil Signed-off-by: Jihoon Son <[email protected]> * the bases should not be an empty string in the error message when the user input is not Signed-off-by: Jihoon Son <[email protected]> * more user-friendly message * Update sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala Co-authored-by: Gera Shegalov <[email protected]> --------- Signed-off-by: Jihoon Son <[email protected]> Co-authored-by: Gera Shegalov <[email protected]>
* Disable ANSI mode for window function tests. Fixes NVIDIA#11019. Window function tests fail on Spark 4.0 because of NVIDIA#5114 (and NVIDIA#5120 broadly), because spark-rapids does not support SUM, COUNT, and certain other aggregations in ANSI mode. This commit disables ANSI mode tests for the failing window function tests. These may be revisited, once error/overflow checking is available for ANSI mode in spark-rapids. Signed-off-by: MithunR <[email protected]> * Switch from @ansi_mode_disabled to @disable_ansi_mode. --------- Signed-off-by: MithunR <[email protected]>
…o-date (NVIDIA#10997) * wip Signed-off-by: Haoyang Li <[email protected]> * fix json suite Signed-off-by: Haoyang Li <[email protected]> * wip Signed-off-by: Haoyang Li <[email protected]> * update Signed-off-by: Haoyang Li <[email protected]> * Remove all utc config and clean up Signed-off-by: Haoyang Li <[email protected]> * hardcode timezone to LA in ci Signed-off-by: Haoyang Li <[email protected]> * remove concat Signed-off-by: Haoyang Li <[email protected]> * remove spark timezone settings and only keep java timezone settings Signed-off-by: Haoyang Li <[email protected]> * remove unintensional comment Signed-off-by: Haoyang Li <[email protected]> * delete a comment Signed-off-by: Haoyang Li <[email protected]> * set timezone to utc for two suites to avoid fallback Signed-off-by: Haoyang Li <[email protected]> * style Signed-off-by: Haoyang Li <[email protected]> * after all Signed-off-by: Haoyang Li <[email protected]> * add cast string to timestamp back to exclude after upmerge Signed-off-by: Haoyang Li <[email protected]> --------- Signed-off-by: Haoyang Li <[email protected]>
Signed-off-by: Haoyang Li <[email protected]>
…DIA#11066) * Replaced spark3xx-common references to spark-shared * Signing off Signed-off-by: Raza Jafri <[email protected]> * addressed review comments * addressed review comments * removed todo as per review comment * Moving dependency to the related module because it was causing an error while running code coverage * Addressed review comments * Regenerated 2.13 poms --------- Signed-off-by: Raza Jafri <[email protected]>
Signed-off-by: Raza Jafri <[email protected]>
* Fixed array_tests * Signing off Signed-off-by: Raza Jafri <[email protected]> * Disable ANSI for failing tests --------- Signed-off-by: Raza Jafri <[email protected]>
* add a heristic to skip agg pass Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * commit doc change Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * refine naming Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * fix only reduction case Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * fix compile Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * fix Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * clean Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * fix doc Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * reduce premergeci2 Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * reduce premergeci2, 2 Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * use test_parallel to workaround flaky array test Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * address review comment Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * remove comma Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * workaround for ci_scala213 Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * disable agg ratio heruistic by default Signed-off-by: Hongbin Ma (Mahone) <[email protected]> * fix doc Signed-off-by: Hongbin Ma (Mahone) <[email protected]> --------- Signed-off-by: Hongbin Ma (Mahone) <[email protected]>
…ttern in rlike. (NVIDIA#11088) * Remove bracket when necessary in PrefixRange patten in Regex rewrite Signed-off-by: Haoyang Li <[email protected]> * add pytest cases Signed-off-by: Haoyang Li <[email protected]> * fix scala 2.13 build Signed-off-by: Haoyang Li <[email protected]> --------- Signed-off-by: Haoyang Li <[email protected]>
) Signed-off-by: xieshuaihu <[email protected]>
* Spark 4: Handle ANSI mode in sort_test.py Fixes NVIDIA#11027. With ANSI mode enabled (like the default in Spark 4), one sees that some tests in `sort_test.py` fail, because they expect ANSI mode to be off. This commit disables running those tests with ANSI enabled, and add a separate test for ANSI on/off. Signed-off-by: MithunR <[email protected]> * Refactored not to use disable_ansi_mode. These tests need not be revisited. They test all combinations of ANSI mode, including overflow failures. Signed-off-by: MithunR <[email protected]> --------- Signed-off-by: MithunR <[email protected]>
* Introduce lore id * Introduce lore id * Fix type * Fix type * Conf * style * part * Dump * Introduce lore framework * Add tests. * Rename test case Signed-off-by: liurenjie1024 <[email protected]> * Fix AQE test * Fix style * Use args to display lore info. * Fix build break * Fix path in loreinfo * Remove path * Fix comments * Update configs * Fix comments * Fix config --------- Signed-off-by: liurenjie1024 <[email protected]>
Signed-off-by: Firestarman <[email protected]>
Signed-off-by: Firestarman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shuffle optimization